vincbeck commented on code in PR #34222:
URL: https://github.com/apache/airflow/pull/34222#discussion_r1321791455
##########
airflow/providers/amazon/aws/triggers/rds.py:
##########
@@ -129,16 +130,21 @@ def __init__(
waiter_max_attempts: int,
aws_conn_id: str,
response: dict[str, Any],
- db_type: RdsDbType,
+ db_type: RdsDbType | str,
Review Comment:
Agree on 2. But on he first point you can define your literal like `db_type
= Literal[...]` and then use and import this one across the code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
