uranusjr commented on code in PR #34291:
URL: https://github.com/apache/airflow/pull/34291#discussion_r1322357757
##########
airflow/models/dag.py:
##########
@@ -305,8 +305,9 @@ class DAG(LoggingMixin):
characters, dashes, dots and underscores (all ASCII)
:param description: The description for the DAG to e.g. be shown on the
webserver
:param schedule: Defines the rules according to which DAG runs are
scheduled. Can
- accept cron string, timedelta object, Timetable, or list of Dataset
objects.
- See also :doc:`/howto/timetable`.
+ accept cron string, timedelta object, Timetable, or list of Dataset
objects.
+ If no schedule (or schedule_interval) is provided, then schedule will
be set
+ to `timedelta(days=1)`. See also :doc:`/howto/timetable`.
Review Comment:
```suggestion
If this is not provided, the DAG will be set to the default
schedule ``timedelta(days=1)``. See also :doc:`/howto/timetable`.
```
Let’s not mention the deprecated argument.
##########
airflow/models/dag.py:
##########
@@ -305,8 +305,9 @@ class DAG(LoggingMixin):
characters, dashes, dots and underscores (all ASCII)
:param description: The description for the DAG to e.g. be shown on the
webserver
:param schedule: Defines the rules according to which DAG runs are
scheduled. Can
- accept cron string, timedelta object, Timetable, or list of Dataset
objects.
- See also :doc:`/howto/timetable`.
+ accept cron string, timedelta object, Timetable, or list of Dataset
objects.
+ If no schedule (or schedule_interval) is provided, then schedule will
be set
+ to `timedelta(days=1)`. See also :doc:`/howto/timetable`.
Review Comment:
```suggestion
If this is not provided, the DAG will be set to the default
schedule ``timedelta(days=1)``. See also :doc:`/howto/timetable`.
```
Let’s not mention the deprecated argument.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
