uranusjr commented on code in PR #34223:
URL: https://github.com/apache/airflow/pull/34223#discussion_r1322464066
##########
dev/assign_cherry_picked_prs_with_milestone.py:
##########
@@ -276,9 +275,7 @@ def assign_prs(
console.print("\n[yellow]Implying --skip-assigned as summary report is
enabled[/]\n")
skip_assigned = True
milestone = repo.get_milestone(milestone_number)
- count_prs = len(prs)
- if limit_pr_count:
- count_prs = limit_pr_count
+ count_prs = limit_pr_count if limit_pr_count else None
Review Comment:
I think the `count_prs` variable is always the same as `limit_pr_count`
(except for `0` but that value doesn’t make practical sense anyway)
##########
dev/assign_cherry_picked_prs_with_milestone.py:
##########
@@ -276,9 +275,7 @@ def assign_prs(
console.print("\n[yellow]Implying --skip-assigned as summary report is
enabled[/]\n")
skip_assigned = True
milestone = repo.get_milestone(milestone_number)
- count_prs = len(prs)
- if limit_pr_count:
- count_prs = limit_pr_count
+ count_prs = limit_pr_count if limit_pr_count else None
Review Comment:
I think the `count_prs` variable is always the same as `limit_pr_count`
(except for `0` but that value doesn’t make practical sense anyway)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
