potiuk commented on code in PR #34269:
URL: https://github.com/apache/airflow/pull/34269#discussion_r1322941286
##########
dev/breeze/src/airflow_breeze/commands/setup_commands.py:
##########
@@ -289,6 +320,11 @@ def get_command_hash_export() -> str:
if "commands" in current_command_dict:
subcommands = current_command_dict["commands"]
for subcommand in sorted(subcommands.keys()):
+ ok = validate_params_for_command(
+ commands_dict[command]["commands"][subcommand],
command + " " + subcommand
+ )
+ if not ok:
+ sys.exit(1)
Review Comment:
Similarly here, it would be great if we just store the status
(duplicates_found) and fail after we iterate through all commands. This way we
wil see immediately all such duplicates if there are more.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
