uranusjr commented on code in PR #34320:
URL: https://github.com/apache/airflow/pull/34320#discussion_r1323958167
##########
airflow/providers/celery/executors/celery_executor_utils.py:
##########
@@ -155,7 +155,7 @@ def _execute_in_fork(command_to_exec: CommandType,
celery_task_id: str | None =
args.func(args)
ret = 0
except Exception as e:
- log.exception("[%s] Failed to execute task %s.", celery_task_id,
str(e))
+ log.exception("[%s] Failed to execute task %s.", celery_task_id, e)
Review Comment:
Probably not belong in this PR but this second argument really isn’t needed
since `exception` would log this automatically.
##########
airflow/providers/celery/executors/celery_executor_utils.py:
##########
@@ -155,7 +155,7 @@ def _execute_in_fork(command_to_exec: CommandType,
celery_task_id: str | None =
args.func(args)
ret = 0
except Exception as e:
- log.exception("[%s] Failed to execute task %s.", celery_task_id,
str(e))
+ log.exception("[%s] Failed to execute task %s.", celery_task_id, e)
Review Comment:
Probably not belong in this PR but this second argument really isn’t needed
since `exception` would log this automatically.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
