Taragolis commented on code in PR #34347:
URL: https://github.com/apache/airflow/pull/34347#discussion_r1324788344
##########
airflow/providers/amazon/aws/utils/identifiers.py:
##########
@@ -46,6 +46,6 @@ def generate_uuid(*values: str | None, namespace: UUID =
NAMESPACE_OID) -> str:
result = namespace
for item in values:
- result = uuid5(result, item if item is not None else str(NIL_UUID))
+ result = uuid5(result, item or str(NIL_UUID))
Review Comment:
In this particular place empty string it is a valid value. I think I even
add test for prevent this change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
