o-nikolas commented on code in PR #34381: URL: https://github.com/apache/airflow/pull/34381#discussion_r1326467448
########## airflow/cli/commands/task_command.py: ########## @@ -46,7 +46,7 @@ from airflow.models.operator import needs_expansion from airflow.models.param import ParamsDict from airflow.models.taskinstance import TaskReturnCode -from airflow.settings import IS_K8S_EXECUTOR_POD +from airflow.settings import IS_EXECUTOR_CONTAINER, IS_K8S_EXECUTOR_POD Review Comment: New mechanism to enable task log output to show up in task logs for containerized executors. A previous mechanism existed for K8s only (a source of executor coupling!) a new one was added, but K8s was not migrated as part of this PR to keep the size down. More changes in settings.py and logging_mixin.py below -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
