o-nikolas commented on code in PR #34381: URL: https://github.com/apache/airflow/pull/34381#discussion_r1327606302
########## airflow/providers/amazon/aws/executors/ecs/Dockerfile: ########## @@ -0,0 +1,86 @@ +# hadolint ignore=DL3007 +FROM apache/airflow:latest +USER root +RUN apt-get update \ + && apt-get install -y --no-install-recommends unzip \ + # The below helps to keep the image size down + && apt-get clean \ + && rm -rf /var/lib/apt/lists/* +RUN curl "https://awscli.amazonaws.com/awscli-exe-linux-x86_64.zip"; -o "awscliv2.zip" +RUN unzip awscliv2.zip && ./aws/install Review Comment: Yupp, we could consider that. Ultimately the goal with this Dockerfile is to provide a very simple and beginner image for folks to play around with. If people are using this in their production workflows, they surely have their own images they're going to build and use all integrated into their CI and pipelines already. So we've gone with the philosophy of not over engineering this one. But this change seems easy/simple enough to make :+1: CC @syedahsn I don't think the install_aws.sh script would be available in this image? If it is we should definitely use it! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
