eumiro commented on code in PR #34404:
URL: https://github.com/apache/airflow/pull/34404#discussion_r1327706269
##########
airflow/settings.py:
##########
@@ -237,9 +237,7 @@ def configure_orm(disable_connection_pool=False,
pool_class=None):
session = Session()
try:
result = session.execute(
- sqlalchemy.text(
- "SELECT is_read_committed_snapshot_on FROM sys.databases
WHERE name=:database_name"
- ),
+ sa.text("SELECT is_read_committed_snapshot_on FROM
sys.databases WHERE name=:database_name"),
Review Comment:
While `alembic` scripts are very sqlalchemy-centric, having `from sqlalchemy
import …` words like `text` or `delete` in a large file looks a bit confusing
to me. I'm fine with either though, but would prefer one way of doing it.
##########
airflow/settings.py:
##########
@@ -237,9 +237,7 @@ def configure_orm(disable_connection_pool=False,
pool_class=None):
session = Session()
try:
result = session.execute(
- sqlalchemy.text(
- "SELECT is_read_committed_snapshot_on FROM sys.databases
WHERE name=:database_name"
- ),
+ sa.text("SELECT is_read_committed_snapshot_on FROM
sys.databases WHERE name=:database_name"),
Review Comment:
While `alembic` scripts are very sqlalchemy-centric, having `from sqlalchemy
import …` words like `text` or `delete` in a large file looks a bit confusing
to me. I'm fine with either though, but would prefer one way of doing it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
