Taragolis commented on code in PR #33557:
URL: https://github.com/apache/airflow/pull/33557#discussion_r1334198843
##########
airflow/providers/slack/hooks/slack.py:
##########
@@ -113,42 +111,31 @@ class SlackHook(BaseHook):
def __init__(
self,
- token: str | None = None,
- slack_conn_id: str | None = None,
+ *,
+ slack_conn_id: str,
Review Comment:
Better say feature. Without removal in this PR it was quite difficult to do
that.
Let's move discussion in to your PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
