ferruzzi commented on issue #34416: URL: https://github.com/apache/airflow/issues/34416#issuecomment-1731479336
Yeah, this is a known issue and the reason for that exemption list and truncation. We can't just rename all of the metrics because that would break back-compat, and that's why many of them are emitted twice (once with everything embedded in the name and once with tags) It looks like those three metrics you called out were added after the change and SHOULD have been implemented with tags instead (and therefor should not have been added to the exemption list... but we didn't catch that in time so I guess it's the best answer) The unit test only makes sure the exemption list isn't changed, it doesn't check for new metrics which might break... maybe some kind of CI test would be wise, to prevent future new metrics from being added which have both `dag_id` and `task_id` in their name... I don't know what that would look like though.... we'd maybe have to parse the raw text of the changes looking for lines starting with `Stats` and including `dag_id` and `task_id` which do not match the exemptions list pattern? maybe? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
