hussein-awala commented on code in PR #34564:
URL: https://github.com/apache/airflow/pull/34564#discussion_r1334766738
##########
tests/api_connexion/endpoints/test_task_instance_endpoint.py:
##########
@@ -210,7 +210,8 @@ def test_should_respond_200(self, username, session):
# This prevents issue when users upgrade to 2.0+
# from 1.10.x
# https://github.com/apache/airflow/issues/14421
- session.query(TaskInstance).update({TaskInstance.operator: None},
synchronize_session="fetch")
+ session.query(TaskInstance).update(
+ {TaskInstance.operator: None}, synchronize_session="fetch")
Review Comment:
Try to avoid unnecessary and unrelated changes
```suggestion
session.query(TaskInstance).update({TaskInstance.operator: None},
synchronize_session="fetch")
```
##########
tests/api_connexion/endpoints/test_task_instance_endpoint.py:
##########
@@ -312,7 +313,8 @@ def
test_should_respond_200_with_task_state_in_deferred(self, session):
}
def test_should_respond_200_with_task_state_in_removed(self, session):
- self.create_task_instances(session, task_instances=[{"state":
State.REMOVED}], update_extras=True)
+ self.create_task_instances(session, task_instances=[
+ {"state": State.REMOVED}],
update_extras=True)
Review Comment:
```suggestion
self.create_task_instances(session, task_instances=[{"state":
State.REMOVED}], update_extras=True)
```
##########
tests/api_connexion/endpoints/test_task_instance_endpoint.py:
##########
@@ -667,7 +669,8 @@ def test_should_respond_200_for_dag_id_filter(self,
session):
)
assert response.status_code == 200
- count = session.query(TaskInstance).filter(TaskInstance.dag_id ==
"example_python_operator").count()
+ count = session.query(TaskInstance).filter(
Review Comment:
```suggestion
count = session.query(TaskInstance).filter(TaskInstance.dag_id ==
"example_python_operator").count()
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
