vincbeck commented on code in PR #34349:
URL: https://github.com/apache/airflow/pull/34349#discussion_r1334788811
##########
airflow/auth/managers/base_auth_manager.py:
##########
@@ -50,6 +50,10 @@ def get_cli_commands() -> list[CLICommand]:
"""
return []
+ def get_api_blueprint(self) -> None | Blueprint:
Review Comment:
I looked at what plugins are and, indeed, plugins offer features that can be
really interesting for auth managers. Example ([see
doc](https://github.com/apache/airflow/pull/34349)), you can easily add
blueprints to your Airflow environment, you can also add views and customize
the Airflow menu which auth managers might need.
However, plugins also offer other features which have nothing to do with
user management. Thus, I am wondering if registering auth managers as plugins
would not open an open door which later we regret because some auth managers
might exploit these extra features and at the end do more than what a auth
manager is supposed to do: user management.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
