hussein-awala commented on code in PR #34573:
URL: https://github.com/apache/airflow/pull/34573#discussion_r1334982438
##########
airflow/providers/google/cloud/operators/bigquery.py:
##########
@@ -560,7 +562,7 @@ def _submit_job(
configuration = {"query": {"query": sql, "useLegacySql":
self.use_legacy_sql}}
return hook.insert_job(
configuration=configuration,
- project_id=hook.project_id,
+ project_id=self.bq_project_id if self.bq_project_id else
hook.project_id,
Review Comment:
```suggestion
project_id=self.bq_project_id or hook.project_id,
```
##########
airflow/providers/google/cloud/operators/bigquery.py:
##########
@@ -532,6 +532,7 @@ def __init__(
labels: dict | None = None,
deferrable: bool = conf.getboolean("operators", "default_deferrable",
fallback=False),
poll_interval: float = 4.0,
+ bq_project_id: str | None = None,
Review Comment:
IMHO we should use `project_id` as we do in the other operators, wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
