Lee-W commented on code in PR #34569:
URL: https://github.com/apache/airflow/pull/34569#discussion_r1335028397
##########
tests/providers/amazon/aws/sensors/test_sqs.py:
##########
@@ -346,3 +346,49 @@ def test_sqs_deferrable(self):
)
with pytest.raises(TaskDeferred):
self.sensor.execute(None)
+
+ @pytest.mark.parametrize(
+ "soft_fail, expected_exception", ((False, AirflowException), (True,
AirflowSkipException))
+ )
+ def test_fail_execute_complete(self, soft_fail, expected_exception):
+ self.sensor = SqsSensor(
+ task_id="test_task_deferrable",
+ dag=self.dag,
+ sqs_queue=QUEUE_URL,
+ aws_conn_id="aws_default",
+ max_messages=1,
+ num_batches=3,
+ deferrable=True,
+ )
+ self.sensor.soft_fail = soft_fail
Review Comment:
```suggestion
deferrable=True,
soft_fail=soft_fail,
)
```
##########
tests/providers/amazon/aws/sensors/test_sqs.py:
##########
@@ -346,3 +346,49 @@ def test_sqs_deferrable(self):
)
with pytest.raises(TaskDeferred):
self.sensor.execute(None)
+
+ @pytest.mark.parametrize(
+ "soft_fail, expected_exception", ((False, AirflowException), (True,
AirflowSkipException))
+ )
+ def test_fail_execute_complete(self, soft_fail, expected_exception):
+ self.sensor = SqsSensor(
+ task_id="test_task_deferrable",
+ dag=self.dag,
+ sqs_queue=QUEUE_URL,
+ aws_conn_id="aws_default",
+ max_messages=1,
+ num_batches=3,
+ deferrable=True,
+ )
+ self.sensor.soft_fail = soft_fail
+ event = {"status": "failed"}
+ message = f"Trigger error: event is {event}"
+ with pytest.raises(expected_exception, match=message):
+ self.sensor.execute_complete(context={}, event=event)
+
+ @pytest.mark.parametrize(
+ "soft_fail, expected_exception", ((False, AirflowException), (True,
AirflowSkipException))
+ )
+ @mock.patch("airflow.providers.amazon.aws.sensors.sqs.SqsSensor.poll_sqs")
+ @mock.patch("airflow.providers.amazon.aws.sensors.sqs.process_response")
+ @mock.patch("airflow.providers.amazon.aws.hooks.sqs.SqsHook.conn")
+ def test_fail_poke(self, conn, process_response, poll_sqs, soft_fail,
expected_exception):
+ self.sensor = SqsSensor(
+ task_id="test_task_deferrable",
+ dag=self.dag,
+ sqs_queue=QUEUE_URL,
+ aws_conn_id="aws_default",
+ max_messages=1,
+ num_batches=3,
+ deferrable=True,
+ )
+ response = "error message"
+ messages = [{"MessageId": "1", "ReceiptHandle": "test"}]
+ poll_sqs.return_value = response
+ process_response.return_value = messages
+ conn.delete_message_batch.return_value = response
+ error_message = f"Delete SQS Messages failed {response} for messages"
+ self.sensor.soft_fail = soft_fail
Review Comment:
```suggestion
```
##########
tests/providers/amazon/aws/sensors/test_sqs.py:
##########
@@ -346,3 +346,49 @@ def test_sqs_deferrable(self):
)
with pytest.raises(TaskDeferred):
self.sensor.execute(None)
+
+ @pytest.mark.parametrize(
+ "soft_fail, expected_exception", ((False, AirflowException), (True,
AirflowSkipException))
+ )
+ def test_fail_execute_complete(self, soft_fail, expected_exception):
+ self.sensor = SqsSensor(
+ task_id="test_task_deferrable",
+ dag=self.dag,
+ sqs_queue=QUEUE_URL,
+ aws_conn_id="aws_default",
+ max_messages=1,
+ num_batches=3,
+ deferrable=True,
+ )
+ self.sensor.soft_fail = soft_fail
+ event = {"status": "failed"}
+ message = f"Trigger error: event is {event}"
+ with pytest.raises(expected_exception, match=message):
+ self.sensor.execute_complete(context={}, event=event)
+
+ @pytest.mark.parametrize(
+ "soft_fail, expected_exception", ((False, AirflowException), (True,
AirflowSkipException))
+ )
+ @mock.patch("airflow.providers.amazon.aws.sensors.sqs.SqsSensor.poll_sqs")
+ @mock.patch("airflow.providers.amazon.aws.sensors.sqs.process_response")
+ @mock.patch("airflow.providers.amazon.aws.hooks.sqs.SqsHook.conn")
+ def test_fail_poke(self, conn, process_response, poll_sqs, soft_fail,
expected_exception):
+ self.sensor = SqsSensor(
+ task_id="test_task_deferrable",
+ dag=self.dag,
+ sqs_queue=QUEUE_URL,
+ aws_conn_id="aws_default",
+ max_messages=1,
+ num_batches=3,
+ deferrable=True,
Review Comment:
```suggestion
deferrable=True,
soft_fail=soft_fail,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
