f0restron07 commented on PR #34568: URL: https://github.com/apache/airflow/pull/34568#issuecomment-1732505475
Hi @Calder-Ty, Thank you for addressing this issue and for reopening the pull request. Making dry_run optional and setting the default to False aligns the behavior of the code with the documentation, which will certainly prevent confusion and errors for API users in the future. It is crucial that the API's behavior is consistent with the documentation to ensure a smooth and reliable user experience, and this change is a step in the right direction. Looking at the commits, it seems you have kept the changes concise and directly related to the issue at hand, which is appreciated. It's also good to see that the checks have mostly passed, indicating that this change doesn't introduce any apparent regressions or new issues. I look forward to seeing this change merged after the required reviews, and I believe it will be a valuable improvement to Apache Airflow. Thank you again for your contribution! Best regards, f0restron -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
