o-nikolas commented on code in PR #34381:
URL: https://github.com/apache/airflow/pull/34381#discussion_r1336389839
##########
airflow/utils/log/logging_mixin.py:
##########
@@ -209,9 +209,9 @@ def __init__(self, stream):
@property
def stream(self):
"""Returns current stream."""
- from airflow.settings import IS_K8S_EXECUTOR_POD
+ from airflow.settings import IS_EXECUTOR_CONTAINER, IS_K8S_EXECUTOR_POD
- if IS_K8S_EXECUTOR_POD:
+ if IS_K8S_EXECUTOR_POD or IS_EXECUTOR_CONTAINER:
Review Comment:
The only issue you'd have is that task logs won't be redirected so the user
wont see the logs they expect. We should document this behaviour, but I'm not
sure we need to set the min version? Sine as long as users are okay with not
seeing task logs they can use older airflow versions. But I'm interested to
hear other people's perspectives on this one.
CC @shubham22
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
