uranusjr commented on code in PR #34620:
URL: https://github.com/apache/airflow/pull/34620#discussion_r1336759573
##########
airflow/exceptions.py:
##########
@@ -424,3 +424,11 @@ def __str__(self):
"Error deserializing result. Note that result deserialization "
"is not supported across major Python versions. Cause: " +
str(self.__cause__)
)
+
+
+class StopDagTest(AirflowException):
Review Comment:
I don’t think there’s anything to gain inheriting from AirflowException. It
might be better to just make this inherit from Exception and put it in `dag.py`
instead.
##########
airflow/exceptions.py:
##########
@@ -424,3 +424,11 @@ def __str__(self):
"Error deserializing result. Note that result deserialization "
"is not supported across major Python versions. Cause: " +
str(self.__cause__)
)
+
+
+class StopDagTest(AirflowException):
Review Comment:
I don’t think there’s anything to gain inheriting from AirflowException. It
might be better to just make this inherit from Exception and put it in `dag.py`
instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
