jedcunningham commented on code in PR #34349:
URL: https://github.com/apache/airflow/pull/34349#discussion_r1337693701


##########
airflow/auth/managers/base_auth_manager.py:
##########
@@ -50,6 +50,10 @@ def get_cli_commands() -> list[CLICommand]:
         """
         return []
 
+    def get_api_blueprint(self) -> None | Blueprint:

Review Comment:
   Are the things auth managers will need to do just blueprints, menu items, 
and cli stuff?
   
   The first 2 are covered with plugins, and the latter is only in providers. I 
could see an argument for exposing cli to plugins also.
   
   I'm not too concerned with 'scope creep' with auth managers optionally being 
plugins. They could simply register themselves anyways...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to