jens-scheffler-bosch commented on code in PR #31301:
URL: https://github.com/apache/airflow/pull/31301#discussion_r1337769835
##########
docs/apache-airflow/core-concepts/params.rst:
##########
@@ -159,6 +159,11 @@ JSON Schema Validation
},
):
+.. note::
+ Schema validation on DAG definitions is only made if a schedule is
defined. If a manual or external trigger
+ is defined (e.g. via ``schedule=None``) then params are validated during
submission. This allows to enforce
+ undefined parameters being defined at trigger time.
+
Review Comment:
Sorry, the not native speaker english... thanks for the feedback. Tried to
re-phrase a bit - better now?
##########
docs/apache-airflow/core-concepts/params.rst:
##########
@@ -309,6 +313,10 @@ The following features are supported in the Trigger UI
Form:
If you want to change values manually, the JSON configuration can be
adjusted. Changes are overridden when form fields change.
- If you want to render custom HTML as form on top of the provided features,
you can use the ``custom_html_form`` attribute.
+.. note::
+ If the field is required you need to specify a valid default value as
well. Exception is if DAG is defined with
Review Comment:
Sorry, the not native speaker english... thanks for the feedback. Tried to
re-phrase a bit - better now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
