SamWheating opened a new pull request, #34635: URL: https://github.com/apache/airflow/pull/34635
closes: https://github.com/apache/airflow/issues/34309 Since we do some weird stuff with the `try_number` property, we have to do some weird stuff in order to properly search / display it in the UI 🥴: 1) Overriding `try_number.expression` so that sqlalchemy only sees the actual `try_number` value when searching or filtering. 2) Swapping in the `prev_attempted_tries` property in place of the `try_number` property in order to display the actual `try_number` value. This causes the UI to function as expect, only showing + filtering on the actual value from the DB: <img width="1880" alt="image" src="https://github.com/apache/airflow/assets/16950874/c2e975df-116a-4404-9206-2697bf55475d";> However, this feels pretty hacky and I think that overriding the `hybrid_property` expression in particular might cause some issues down the line. I am going to see how complicated it would be to remove the weird try_number property altogether, moving the `try_number+1` logic to a separate property or selectively incrementing the value where required. All feedback and suggestions welcome. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
