amoghrajesh commented on PR #34621: URL: https://github.com/apache/airflow/pull/34621#issuecomment-1736641289
> I’d rather set this to false _for this repository only_. We can do this by intructing the user to set the config to _false_ and without the `--global` flag. This ensures everyone on every platform uses Linux line endings for every file in this repository, and with modern Windows editors (including Notepad!) all being able to handle LF anyway, this should be good enough for any contributors. > > Whether setting automatic CRLF conversion is a good idea varies from project to project, and I would most definitely prefer to not encourage a contirbutor to set this globally and pollute the entire machine. And in the case a project wants a non-default setting, _true_ is almost never the right choice unless the project only targets Windows, which Airflow most certainly does not. Good point. We should not do this globally at all. Coming to the value, does "false" seem like a more reasonable approach? I would prefer special instructions for the windows user since they are less in number and having such a instruction would be an ideal scenario -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
