krisfur commented on code in PR #34627:
URL: https://github.com/apache/airflow/pull/34627#discussion_r1338172298
##########
airflow/providers/microsoft/azure/hooks/container_instance.py:
##########
@@ -177,6 +177,8 @@ def get_logs(self, resource_group: str, name: str, tail:
int = 1000) -> list:
:return: A list of log messages
"""
logs = self.connection.containers.list_logs(resource_group, name,
name, tail=tail)
+ if logs.content is None:
Review Comment:
Thanks, changed return type to list as suggested. Made it [None] and built
in a check for the list being longer than 0 and having first index be None to
not experience index issues at the start of the run when logs is an empty list
- all tested on our setup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
