krisfur commented on code in PR #34627:
URL: https://github.com/apache/airflow/pull/34627#discussion_r1340995479
##########
airflow/providers/microsoft/azure/operators/container_instances.py:
##########
@@ -319,6 +319,9 @@ def _monitor_logging(self, resource_group: str, name: str)
-> int:
if state in ["Running", "Terminated", "Succeeded"]:
try:
logs = self._ci_hook.get_logs(resource_group, name)
+ if logs is None:
+ self.log.exception("Container log is broken,
marking as failed.")
Review Comment:
I'm equally surprised haha. I'm suspecting this could be an issue Azure side
that airflow just draws out when asking for logs at that error point. Do you
have better contact with Azure devs (compared to a basic client) to maybe ask
them?
`executor = LocalExecutor`
DB backend: `postgresql+psycopg2`
I suppose if we can't find the root of the issue then it would be prudent to
at least handle this error since choosing no restarts and still getting
restarts is quite problematic (and if we return 1 on this error then onFailure
restarts will trigger properly anyway if someone has them turned on).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
