Taragolis commented on code in PR #34693: URL: https://github.com/apache/airflow/pull/34693#discussion_r1342005721
########## airflow/providers/amazon/aws/hooks/opensearch.py: ########## @@ -0,0 +1,130 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +from __future__ import annotations + +import json +from typing import Any + +from opensearchpy import AWSV4SignerAuth, OpenSearch, RequestsHttpConnection + +from airflow.exceptions import AirflowException +from airflow.providers.amazon.aws.hooks.base_aws import AwsBaseHook + + +class OpenSearchHook(AwsBaseHook): + """ + This Hook provides a thin wrapper around the OpenSearch client. Review Comment: Yeah it how it works in general. There is some exceptions but most (if not all) of them created years ago. there is also exists hooks in Amazon Provider which not depends on `AwsBaseHook`, example: - [`RedshiftSQLHook`](https://github.com/apache/airflow/blob/c645d8e40c167ea1f6c332cdc3ea0ca5a9363205/airflow/providers/amazon/aws/hooks/redshift_sql.py#L35) - [`ChimeWebhookHook`](https://github.com/apache/airflow/blob/a7310f9c9127cf87a71e0bfa141c066d6a0bc82b/airflow/providers/amazon/aws/hooks/chime.py#L31) `AwsBaseHook` it wrapper around one of the `boto3` (`botocore`) clients, e.g. - [`osis`](https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/osis.html) - [`opensearch `](https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/opensearch.html) - [`opensearchserverless`](https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/opensearchserverless.html) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
