vincbeck commented on code in PR #33213:
URL: https://github.com/apache/airflow/pull/33213#discussion_r1344123947
##########
airflow/www/auth.py:
##########
@@ -35,16 +44,100 @@ def get_access_denied_message():
return conf.get("webserver", "access_denied_message")
-def has_access(permissions: Sequence[tuple[str, str]] | None = None) ->
Callable[[T], T]:
Review Comment:
Sadly this is really impossible to keep all the code in case someone uses
that code in their own code (DAGs, plugins, ...). This goes back to definition
of [public interface in
Airflow](https://airflow.apache.org/docs/apache-airflow/stable/public-airflow-interface.html)
and the security manager is not part of it. However, there is an option in
Airflow where you can bring your own security manager using the constant
`SECURITY_MANAGER_CLASS`, even though this is not part of the public interface
we did no want to break user experience in case they are using a custom
security manager so we handled it. But in your case, I feel like you need to
update your code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
