Taragolis commented on code in PR #34744:
URL: https://github.com/apache/airflow/pull/34744#discussion_r1347171880
##########
airflow/utils/timezone.py:
##########
@@ -273,3 +279,24 @@ def _format_part(key: str) -> str:
if not joined:
return "<1s"
return joined
+
+
+@lru_cache(maxsize=None)
+def parse_timezone(name: str | int) -> Timezone | FixedTimezone:
Review Comment:
> just Timezone should be sufficient?
https://github.com/apache/airflow/pull/34744#discussion_r1347070794
> What about the parameter name? That looks a bit awkward if you are
checking for an int. What about tz and making it part of the docstring?
This is basically reimplementation of pendulum parse function, so I keep the
same attribute `name` but I have no objection if we would like to rename it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
