Zhenye-Na opened a new pull request, #34791:
URL: https://github.com/apache/airflow/pull/34791
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: [#ISSUE](https://github.com/apache/airflow/issues/34756)
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
### Notes
This PR closes: https://github.com/apache/airflow/issues/34756
### Testing
```
pre-commit run --all-files
Check if all hooks apply to the
repository.........................................Passed
Add TOC for Markdown and RST
files.................................................Passed
Add license for all SQL
files......................................................Passed
Add license for all RST
files......................................................Passed
Add license for all CSS/JS/JSX/PUML/TS/TSX
files...................................Passed
Add license for all JINJA template
files...........................................Passed
Add license for all Shell
files....................................................Passed
Add license for all Python
files...................................................Passed
Add license for all XML
files......................................................Passed
Add license for all Helm template
files............................................Passed
Add license for all YAML files except Helm
templates...............................Passed
Add license for all Markdown
files.................................................Passed
Add license for all other
files....................................................Passed
Run black (Python
formatter).......................................................Passed
Check and update common.sql API
stubs..............................................Passed
Update black versions
everywhere...................................................Passed
ruff...............................................................................Passed
Run black on Python code blocks in documentation
files.............................Passed
Check that merge conflicts are not being
committed.................................Passed
Detect accidentally committed debug
statements.....................................Passed
Require literal syntax when initializing builtin
types.............................Passed
Detect if private key is added to the
repository...................................Passed
Make sure that there is an empty line at the
end...................................Passed
Detect if mixed line ending is used (\r vs.
\r\n)..................................Passed
Check that executables have
shebang................................................Passed
Check XML files with
xmllint.......................................................Passed
Remove trailing whitespace at end of
line..........................................Passed
Remove encoding header from Python
files...........................................Passed
Format JSON
files..................................................................Passed
Check if RST files use double backticks for
code...................................Passed
Check if there are no deprecate log
warn...........................................Passed
Check YAML files with
yamllint.....................................................Passed
Run flynt string format converter for
Python.......................................Passed
Run codespell to check for common misspellings in
files............................Passed
Validate
pyproject.toml............................................................Passed
Replace bad
characters.............................................................Passed
Lint OpenAPI using
spectral........................................................Passed
Lint OpenAPI using
openapi-spec-validator..........................................Passed
Lint
Dockerfile....................................................................Passed
Check order of dependencies in setup.cfg and
setup.py..............................Passed
Check airflow.kubernetes imports are not
used......................................Passed
Check cncf.kubernetes imports used for executors
only..............................Passed
Checks setup extra
packages........................................................Passed
Check compatibility of Providers with
Airflow......................................Passed
Check google-re2 is declared as dependency when
needed.............................Passed
Update mounts in the local yml
file................................................Passed
Update cross-dependencies for providers
packages...................................Passed
Update extras in
documentation.....................................................Passed
Check order of extras in
Dockerfile................................................Passed
Updates supported versions in
documentation........................................Passed
Check that the REVISION_HEADS_MAP is
up-to-date....................................Passed
Update version to the latest version in the
documentation..........................Passed
Check for pydevd debug statements accidentally
left................................Passed
Verify example dags do not use hard-coded version
numbers..........................Passed
Don't use safe in
templates........................................................Passed
No providers imports in core example
DAGs..........................................Passed
Do not use DeprecationWarning in
providers.........................................Passed
No relative
imports................................................................Passed
Don't use urlparse in
code.........................................................Passed
Check NEW_SESSION is only used with
@provide_session...............................Passed
Check for language that we do not accept as
community..............................Passed
Check BaseOperator and partial()
arguments.........................................Passed
Check model __init__ and decorator arguments are in
sync...........................Passed
Check BaseOperator[Link] core
imports..............................................Passed
Check BaseOperator[Link] other
imports.............................................Passed
Check @task decorator implements
custom_operator_name..............................Passed
Verify usage of Airflow deprecation classes in
core................................Passed
Check provide_session and create_session
imports...................................Passed
Make sure LoggingMixin is not used
alone...........................................Passed
Make sure days_ago is imported from
airflow.utils.dates............................Passed
start_date not to be defined in default_args in
example_dags.......................Passed
Check if licenses are OK for
Apache................................................Passed
Check if aiobotocore is an optional dependency
only................................Passed
Checks for Boring Cyborg configuration
consistency.................................Passed
Sort INTHEWILD.md
alphabetically...................................................Passed
Sort alphabetically and uniquify
installed_providers.txt...........................Passed
Sort alphabetically and uniquify
spelling_wordlist.txt.............................Passed
Lint Helm
Chart....................................................................Passed
Check Shell scripts syntax
correctness.............................................Passed
stylelint..........................................................................Passed
Provider init file is
missing......................................................Passed
Provider subpackage init files are
there...........................................Passed
Validate hook IDs & names and sync with
docs.......................................Passed
Update Breeze README.md with config files
hash.....................................Passed
Breeze should have small number of top-level
dependencies..........................Passed
Check if system tests have required segments of
code...............................Passed
Generate PyPI
README...............................................................Passed
Run
markdownlint...................................................................Passed
Lint JSON Schema files with JSON
Schema............................................Passed
Lint NodePort Service with JSON
Schema.............................................Passed
Lint Docker compose files with JSON
Schema.........................................Passed
Lint chart/values.schema.json file with JSON
Schema................................Passed
Vendor k8s definitions into
values.schema.json.....................................Passed
Lint chart/values.yaml file with JSON
Schema.......................................Passed
Lint config_templates/config.yml file with JSON
Schema.............................Passed
Check that workflow files have persist-credentials
disabled........................Passed
Check that docstrings do not specify param
types...................................Passed
Lint chart/values.schema.json
file.................................................Passed
Inline Dockerfile and Dockerfile.ci
scripts........................................Passed
Check changelogs for duplicate
entries.............................................Passed
Check newsfragments are
valid......................................................Passed
Update output of breeze commands in
BREEZE.rst.....................................Passed
Check that example dags url include provider
versions..............................Passed
Check that system tests is properly
added..........................................Passed
Check that all logging methods are
lazy............................................Passed
Create missing init.py files in
tests..............................................Passed
TS types generation / ESLint / Prettier against UI
files...........................Passed
Check that unit tests do not inherit from
unittest.TestCase........................Passed
Use re2 module instead of
re.......................................................Passed
Check default value of deferrable
attribute........................................Passed
Run mypy for
dev...................................................................Failed
- hook id: mypy-dev
- exit code: 1
The image ghcr.io/Zhenye-Na/airflow/main/ci/python3.8 is not available
```
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)**
for more information.
In case of fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a
newsfragment file, named `{pr_number}.significant.rst` or
`{issue_number}.significant.rst`, in
[newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
