Taragolis commented on code in PR #34784:
URL: https://github.com/apache/airflow/pull/34784#discussion_r1348066197
##########
airflow/providers/amazon/aws/hooks/base_aws.py:
##########
@@ -463,15 +463,17 @@ def __init__(
region_name: str | None = None,
client_type: str | None = None,
resource_type: str | None = None,
- config: Config | None = None,
+ config: Config | dict[str, Any] | None = None,
) -> None:
super().__init__()
self.aws_conn_id = aws_conn_id
self.client_type = client_type
self.resource_type = resource_type
self._region_name = region_name
- self._config = config
+ if config and isinstance(config, dict):
+ config = Config(**config)
+ self._config = config or None
Review Comment:
A bit dumb check, however it required to pass tests, some of AWS test patch
`isinstance` as result `isinstance(None, dict)` evaluate as True
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
