Taragolis commented on code in PR #34804:
URL: https://github.com/apache/airflow/pull/34804#discussion_r1348718064
##########
setup.py:
##########
@@ -462,7 +462,7 @@ def write_version(filename: str = str(AIRFLOW_SOURCES_ROOT
/ "airflow" / "git_ve
_devel_only_tests = [
"aioresponses",
- "backports.zoneinfo>=0.2.1;python_version<'3.9'",
+ "backports.zoneinfo>=0.2.1",
Review Comment:
I think we have to limit `backports.zoneinfo`
The builds failed in python 3.10 and 3.11
```
#55 195.8 × Building wheel for backports.zoneinfo (pyproject.toml) did not
run successfully.
#55 195.8 │ exit code: 1
#55 195.8 ╰─> [55 lines of output]
#55 195.8
/tmp/pip-build-env-2iu_fpi3/overlay/lib/python3.10/site-packages/setuptools/config/setupcfg.py:293:
_DeprecatedConfig: Deprecated config in `setup.cfg`
#55 195.8 !!
#55 195.8
#55 195.8
********************************************************************************
#55 195.8 The license_file parameter is deprecated, use
license_files instead.
#55 195.8
#55 195.8 By 2023-Oct-30, you need to update your project
and remove deprecated calls
#55 195.8 or your builds will no longer be supported.
#55 195.8
#55 195.8 See
https://setuptools.pypa.io/en/latest/userguide/declarative_config.html for
details.
#55 195.8
********************************************************************************
#55 195.8
#55 195.8 !!
#55 195.8 parsed = self.parsers.get(option_name, lambda x:
x)(value)
#55 195.8 running bdist_wheel
#55 195.8 running build
#55 195.8 running build_py
#55 195.8 creating build
#55 195.8 creating build/lib.linux-x86_64-cpython-310
#55 195.8 creating build/lib.linux-x86_64-cpython-310/backports
#55 195.8 copying src/backports/__init__.py ->
build/lib.linux-x86_64-cpython-310/backports
#55 195.8 creating
build/lib.linux-x86_64-cpython-310/backports/zoneinfo
#55 195.8 copying src/backports/zoneinfo/_zoneinfo.py ->
build/lib.linux-x86_64-cpython-310/backports/zoneinfo
#55 195.8 copying src/backports/zoneinfo/_version.py ->
build/lib.linux-x86_64-cpython-310/backports/zoneinfo
#55 195.8 copying src/backports/zoneinfo/_tzpath.py ->
build/lib.linux-x86_64-cpython-310/backports/zoneinfo
#55 195.8 copying src/backports/zoneinfo/_common.py ->
build/lib.linux-x86_64-cpython-310/backports/zoneinfo
#55 195.8 copying src/backports/zoneinfo/__init__.py ->
build/lib.linux-x86_64-cpython-310/backports/zoneinfo
#55 195.8 running egg_info
#55 195.8 writing src/backports.zoneinfo.egg-info/PKG-INFO
#55 195.8 writing dependency_links to
src/backports.zoneinfo.egg-info/dependency_links.txt
#55 195.8 writing requirements to
src/backports.zoneinfo.egg-info/requires.txt
#55 195.8 writing top-level names to
src/backports.zoneinfo.egg-info/top_level.txt
#55 195.8 reading manifest file
'src/backports.zoneinfo.egg-info/SOURCES.txt'
#55 195.8 reading manifest template 'MANIFEST.in'
#55 195.8 warning: no files found matching '*.png' under directory
'docs'
#55 195.8 warning: no files found matching '*.svg' under directory
'docs'
#55 195.8 no previously-included directories found matching
'docs/_build'
#55 195.8 no previously-included directories found matching
'docs/_output'
#55 195.8 adding license file 'LICENSE'
#55 195.8 adding license file 'licenses/LICENSE_APACHE'
#55 195.8 writing manifest file
'src/backports.zoneinfo.egg-info/SOURCES.txt'
#55 195.8 copying src/backports/zoneinfo/__init__.pyi ->
build/lib.linux-x86_64-cpython-310/backports/zoneinfo
#55 195.8 copying src/backports/zoneinfo/py.typed ->
build/lib.linux-x86_64-cpython-310/backports/zoneinfo
#55 195.8 running build_ext
#55 195.8 building 'backports.zoneinfo._czoneinfo' extension
#55 195.8 creating build/temp.linux-x86_64-cpython-310
#55 195.8 creating build/temp.linux-x86_64-cpython-310/lib
#55 195.8 gcc -pthread -Wno-unused-result -Wsign-compare -DNDEBUG -g
-fwrapv -O3 -Wall -fPIC -I/usr/local/include/python3.10 -c
lib/zoneinfo_module.c -o
build/temp.linux-x86_64-cpython-310/lib/zoneinfo_module.o -std=c99
#55 195.8 lib/zoneinfo_module.c: In function ‘zoneinfo_fromutc’:
#55 195.8 lib/zoneinfo_module.c:600:19: error: ‘_PyLong_One’
undeclared (first use in this function); did you mean ‘_PyLong_New’?
#55 195.8 600 | one = _PyLong_One;
#55 195.8 | ^~~~~~~~~~~
#55 195.8 | _PyLong_New
#55 195.8 lib/zoneinfo_module.c:600:19: note: each undeclared
identifier is reported only once for each function it appears in
#55 195.8 error: command '/usr/bin/gcc' failed with exit code 1
#55 195.8 [end of output]
#55 195.8
#55 195.8 note: This error originates from a subprocess, and is likely
not a problem with pip.
#55 195.8 ERROR: Failed building wheel for backports.zoneinfo
```
##########
setup.py:
##########
@@ -462,7 +462,7 @@ def write_version(filename: str = str(AIRFLOW_SOURCES_ROOT
/ "airflow" / "git_ve
_devel_only_tests = [
"aioresponses",
- "backports.zoneinfo>=0.2.1;python_version<'3.9'",
+ "backports.zoneinfo>=0.2.1",
Review Comment:
I think we have to limit `backports.zoneinfo`
The builds failed in python 3.10 and 3.11
```
#55 195.8 × Building wheel for backports.zoneinfo (pyproject.toml) did not
run successfully.
#55 195.8 │ exit code: 1
#55 195.8 ╰─> [55 lines of output]
#55 195.8
/tmp/pip-build-env-2iu_fpi3/overlay/lib/python3.10/site-packages/setuptools/config/setupcfg.py:293:
_DeprecatedConfig: Deprecated config in `setup.cfg`
#55 195.8 !!
#55 195.8
#55 195.8
********************************************************************************
#55 195.8 The license_file parameter is deprecated, use
license_files instead.
#55 195.8
#55 195.8 By 2023-Oct-30, you need to update your project
and remove deprecated calls
#55 195.8 or your builds will no longer be supported.
#55 195.8
#55 195.8 See
https://setuptools.pypa.io/en/latest/userguide/declarative_config.html for
details.
#55 195.8
********************************************************************************
#55 195.8
#55 195.8 !!
#55 195.8 parsed = self.parsers.get(option_name, lambda x:
x)(value)
#55 195.8 running bdist_wheel
#55 195.8 running build
#55 195.8 running build_py
#55 195.8 creating build
#55 195.8 creating build/lib.linux-x86_64-cpython-310
#55 195.8 creating build/lib.linux-x86_64-cpython-310/backports
#55 195.8 copying src/backports/__init__.py ->
build/lib.linux-x86_64-cpython-310/backports
#55 195.8 creating
build/lib.linux-x86_64-cpython-310/backports/zoneinfo
#55 195.8 copying src/backports/zoneinfo/_zoneinfo.py ->
build/lib.linux-x86_64-cpython-310/backports/zoneinfo
#55 195.8 copying src/backports/zoneinfo/_version.py ->
build/lib.linux-x86_64-cpython-310/backports/zoneinfo
#55 195.8 copying src/backports/zoneinfo/_tzpath.py ->
build/lib.linux-x86_64-cpython-310/backports/zoneinfo
#55 195.8 copying src/backports/zoneinfo/_common.py ->
build/lib.linux-x86_64-cpython-310/backports/zoneinfo
#55 195.8 copying src/backports/zoneinfo/__init__.py ->
build/lib.linux-x86_64-cpython-310/backports/zoneinfo
#55 195.8 running egg_info
#55 195.8 writing src/backports.zoneinfo.egg-info/PKG-INFO
#55 195.8 writing dependency_links to
src/backports.zoneinfo.egg-info/dependency_links.txt
#55 195.8 writing requirements to
src/backports.zoneinfo.egg-info/requires.txt
#55 195.8 writing top-level names to
src/backports.zoneinfo.egg-info/top_level.txt
#55 195.8 reading manifest file
'src/backports.zoneinfo.egg-info/SOURCES.txt'
#55 195.8 reading manifest template 'MANIFEST.in'
#55 195.8 warning: no files found matching '*.png' under directory
'docs'
#55 195.8 warning: no files found matching '*.svg' under directory
'docs'
#55 195.8 no previously-included directories found matching
'docs/_build'
#55 195.8 no previously-included directories found matching
'docs/_output'
#55 195.8 adding license file 'LICENSE'
#55 195.8 adding license file 'licenses/LICENSE_APACHE'
#55 195.8 writing manifest file
'src/backports.zoneinfo.egg-info/SOURCES.txt'
#55 195.8 copying src/backports/zoneinfo/__init__.pyi ->
build/lib.linux-x86_64-cpython-310/backports/zoneinfo
#55 195.8 copying src/backports/zoneinfo/py.typed ->
build/lib.linux-x86_64-cpython-310/backports/zoneinfo
#55 195.8 running build_ext
#55 195.8 building 'backports.zoneinfo._czoneinfo' extension
#55 195.8 creating build/temp.linux-x86_64-cpython-310
#55 195.8 creating build/temp.linux-x86_64-cpython-310/lib
#55 195.8 gcc -pthread -Wno-unused-result -Wsign-compare -DNDEBUG -g
-fwrapv -O3 -Wall -fPIC -I/usr/local/include/python3.10 -c
lib/zoneinfo_module.c -o
build/temp.linux-x86_64-cpython-310/lib/zoneinfo_module.o -std=c99
#55 195.8 lib/zoneinfo_module.c: In function ‘zoneinfo_fromutc’:
#55 195.8 lib/zoneinfo_module.c:600:19: error: ‘_PyLong_One’
undeclared (first use in this function); did you mean ‘_PyLong_New’?
#55 195.8 600 | one = _PyLong_One;
#55 195.8 | ^~~~~~~~~~~
#55 195.8 | _PyLong_New
#55 195.8 lib/zoneinfo_module.c:600:19: note: each undeclared
identifier is reported only once for each function it appears in
#55 195.8 error: command '/usr/bin/gcc' failed with exit code 1
#55 195.8 [end of output]
#55 195.8
#55 195.8 note: This error originates from a subprocess, and is likely
not a problem with pip.
#55 195.8 ERROR: Failed building wheel for backports.zoneinfo
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
