BasPH commented on code in PR #34487:
URL: https://github.com/apache/airflow/pull/34487#discussion_r1349925772
##########
airflow/dag_processing/manager.py:
##########
@@ -466,6 +475,12 @@ def __init__(
else {}
)
+ dags_directory_event_handler =
AirflowFileSystemEventHandler(dag_file_processor_manager=self)
+ self.observer = Observer() # Class watching for file system changes
+ self.observer.schedule(
+ event_handler=dags_directory_event_handler,
path=str(self._dag_directory), recursive=True
+ )
Review Comment:
If watchdog doesn't find an API for observing filesystem changes, it will
fall back to polling:
https://python-watchdog.readthedocs.io/en/stable/installation.html?highlight=polling#supported-platforms-and-caveats.
I don't know how much this impacts IO compared to the current implementation,
that's something to be tested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
