jedcunningham commented on code in PR #34809:
URL: https://github.com/apache/airflow/pull/34809#discussion_r1351443468
##########
docs/apache-airflow/administration-and-deployment/production-deployment.rst:
##########
@@ -60,8 +60,8 @@ Airflow uses
:class:`~airflow.executors.sequential_executor.SequentialExecutor`
nature, the user is limited to executing at most one task at a time.
``Sequential Executor`` also pauses
the scheduler when it runs a task, hence it is not recommended in a production
setup. You should use the
:class:`~airflow.executors.local_executor.LocalExecutor` for a single machine.
-For a multi-node setup, you should use the :doc:`Kubernetes executor
<../core-concepts/executor/kubernetes>` or
-the :doc:`Celery executor <../core-concepts/executor/celery>`.
+For a multi-node setup, you should use the :doc:`Kubernetes executor
<.apache-airflow-providers-cncf-kubernetes:kubernetes_executor>` or
Review Comment:
```suggestion
For a multi-node setup, you should use the :doc:`Kubernetes executor
<apache-airflow-providers-cncf-kubernetes:kubernetes_executor>` or
```
##########
docs/apache-airflow/core-concepts/executor/index.rst:
##########
@@ -51,28 +51,27 @@ If you want to check which executor is currently set, you
can use the ``airflow
Executor Types
--------------
-There are two types of executor - those that run tasks *locally* (inside the
``scheduler`` process), and those that run their tasks *remotely* (usually via
a pool of *workers*). Airflow comes configured with the ``SequentialExecutor``
by default, which is a local executor, and the safest option for execution, but
we *strongly recommend* you change this to ``LocalExecutor`` for small,
single-machine installations, or one of the remote executors for a
multi-machine/cloud installation.
+Executors are primarily responsible for determining where :doc:`task instances
</core-concepts/tasks>` are executed, as well as managing the state of task
instances. Executors have a common API and are "pluggable", meaning you can
swap executors based on your installation needs.
**Local Executors**
.. toctree::
:maxdepth: 1
- debug
local
sequential
-**Remote Executors**
+The DebugExecutor also exists but has been deprecated in favor of using the
``dag.test()`` command for :doc:`debugging <../debug>`.
-.. toctree::
- :maxdepth: 1
- celery
- celery_kubernetes
- dask
- kubernetes
- local_kubernetes
+**Remote Executors**
+
+* :doc:`CeleryExecutor apache-airflow-providers-celery:celery_executor`
+* :doc:`CeleryKubernetesExecutor
apache-airflow-providers-celery:celery_kubernetes_executor`
+* :doc:`DaskExecutor apache-airflow-providers-daskexecutor:dask_executor`
Review Comment:
```suggestion
* :doc:`CeleryExecutor <apache-airflow-providers-celery:celery_executor>`
* :doc:`CeleryKubernetesExecutor
<apache-airflow-providers-celery:celery_kubernetes_executor>`
* :doc:`DaskExecutor <apache-airflow-providers-daskexecutor:dask_executor>`
```
[Maybe like this
example](https://github.com/apache/airflow/blob/9a297380558420cc2f73a409e350f333530e279e/docs/apache-airflow/configurations-ref.rst?plain=1#L38)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
