kaxil commented on code in PR #34801:
URL: https://github.com/apache/airflow/pull/34801#discussion_r1352313431
##########
airflow/providers/openlineage/extractors/base.py:
##########
@@ -82,7 +82,7 @@ def extract(self) -> OperatorLineage | None:
self.operator.__class__.__module__ + "." +
self.operator.__class__.__name__
)
if fully_qualified_class_name in self.disabled_operators:
- self.log.warning(
+ self.log.info(
Review Comment:
This should be DEBUG too, no? i.e user performed an action to disable the
lineage for specific operators
##########
airflow/providers/openlineage/plugins/listener.py:
##########
@@ -194,14 +194,14 @@ def on_dag_run_running(self, dag_run: DagRun, msg: str):
@hookimpl
def on_dag_run_success(self, dag_run: DagRun, msg: str):
if not self.executor:
- self.log.error("Executor have not started before
`on_dag_run_success`")
+ self.log.warning("Executor have not started before
`on_dag_run_success`")
Review Comment:
```suggestion
self.log.debug("Executor have not started before
`on_dag_run_success`")
```
##########
airflow/providers/openlineage/extractors/base.py:
##########
@@ -144,10 +144,10 @@ def _get_openlineage_facets(self, get_facets_method,
*args) -> OperatorLineage |
job_facets=facets.job_facets,
)
except ImportError:
- self.log.exception(
+ self.log.error(
Review Comment:
```suggestion
self.log.exception(
```
exception seems fine here
##########
airflow/providers/openlineage/plugins/listener.py:
##########
@@ -194,14 +194,14 @@ def on_dag_run_running(self, dag_run: DagRun, msg: str):
@hookimpl
def on_dag_run_success(self, dag_run: DagRun, msg: str):
if not self.executor:
- self.log.error("Executor have not started before
`on_dag_run_success`")
+ self.log.warning("Executor have not started before
`on_dag_run_success`")
return
self.executor.submit(self.adapter.dag_success, dag_run=dag_run,
msg=msg)
@hookimpl
def on_dag_run_failed(self, dag_run: DagRun, msg: str):
if not self.executor:
- self.log.error("Executor have not started before
`on_dag_run_failed`")
+ self.log.warning("Executor have not started before
`on_dag_run_failed`")
Review Comment:
```suggestion
self.log.debug("Executor have not started before
`on_dag_run_failed`")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
