uranusjr commented on code in PR #34851:
URL: https://github.com/apache/airflow/pull/34851#discussion_r1355543632
##########
airflow/config_templates/config.yml:
##########
@@ -2237,6 +2237,16 @@ scheduler:
type: string
example: ~
default: "15"
+ default_cron_timetable:
+ description: |
+ Which Timetable to use when a cron string is provided to `schedule`
argument of
+ a DAG. CronDataIntervalTimetable is the legacy Airflow behavior
suitable for
+ DAGs with well-defined data_interval. CronTriggerTimetable is closer
to the
+ behavior of cron itself.
+ version_added: 2.8.0
+ type: string
+ example: ~
+ default: "CronDataIntervalTimetable"
Review Comment:
If only the two timetables are allowed, I’d want to hide the timetables
entirely and just have a boolean e.g. `legacy_cron_data_intervals` to switch
between the two
##########
airflow/config_templates/config.yml:
##########
@@ -2237,6 +2237,16 @@ scheduler:
type: string
example: ~
default: "15"
+ default_cron_timetable:
+ description: |
+ Which Timetable to use when a cron string is provided to `schedule`
argument of
+ a DAG. CronDataIntervalTimetable is the legacy Airflow behavior
suitable for
+ DAGs with well-defined data_interval. CronTriggerTimetable is closer
to the
+ behavior of cron itself.
+ version_added: 2.8.0
+ type: string
+ example: ~
+ default: "CronDataIntervalTimetable"
Review Comment:
If only the two timetables are allowed, I’d want to hide the timetables
entirely and just have a boolean e.g. `legacy_cron_data_intervals` to switch
between the two
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
