Taragolis commented on code in PR #34874:
URL: https://github.com/apache/airflow/pull/34874#discussion_r1355831314
##########
airflow/providers/google/cloud/hooks/cloud_run.py:
##########
@@ -113,9 +113,11 @@ def update_job(
@GoogleBaseHook.fallback_to_default_project_id
def execute_job(
- self, job_name: str, region: str, project_id: str = PROVIDE_PROJECT_ID
+ self, job_name: str, region: str, overrides: dict | None = None,
project_id: str = PROVIDE_PROJECT_ID
Review Comment:
```suggestion
self, job_name: str, region: str, project_id: str =
PROVIDE_PROJECT_ID, overrides: dict | None = None
```
Because in this method parameters is not keywords only better to add new
parameters in the end of method. This should minimise risk that changes breaks
someone pipeline
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
