Joffreybvn commented on PR #34669:
URL: https://github.com/apache/airflow/pull/34669#issuecomment-1759136750

   Everything in one single Http Operator is indeed simpler ! From a user point 
of view, I get the docstring on my IDE and can opt-in to a pagination feature 
just by providing the required parameter. This was the idea of [the first 
PR](https://github.com/apache/airflow/pull/34606).
   
   But shouldn't the `SimpleHttpOperator` be renamed then ? Because looping 
over pages is not a "simple http call" anymore. Maybe just calling it 
`HttpOperator` ?
   
   Or `BaseHttpOperator` ? In this PR, the SimpleHttpOperator is rewritten to 
be more modular, following what was done for the BaseSQLOperator. It will be 
easier to create other Operators on top of it (typically to do data ingestion).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to