fdemiane commented on code in PR #34755:
URL: https://github.com/apache/airflow/pull/34755#discussion_r1356455859
##########
airflow/providers/google/cloud/hooks/cloud_run.py:
##########
@@ -175,4 +175,6 @@ def get_conn(self):
return self._client
async def get_operation(self, operation_name: str) ->
operations_pb2.Operation:
- return await
self.get_conn().get_operation(operations_pb2.GetOperationRequest(name=operation_name))
+ return await self.get_conn().get_operation(
+ operations_pb2.GetOperationRequest(name=operation_name),
timeout=120
Review Comment:
@Lee-W Thank you for the comment, I don't think it makes sense to make it
configurable. By default the operation is never expected to timeout. The
timeout I added was just to make sure that the client has enough time to fetch
the operation status from the CloudRun service/database in case of (let's say)
load.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
