MemphisMeng opened a new issue, #34897:
URL: https://github.com/apache/airflow/issues/34897

   ### What do you see as an issue?
   
   I was learning how to customize a timetable by following the example on the 
[documentation](https://airflow.apache.org/docs/apache-airflow/stable/howto/timetable.html#parameterized-timetables).
 From my perspective the description overlooks the condition where the earliest 
start time does not fall on midnight. In the snippet of `AfterWorkdayTimetable` 
example, since we assume the DAG is going to run at 12 AM, or say, 00:00 UTC, 
it's logically correct to do `next_start.time() != Time.min`. However, if a 
user parametized the time, there would be 2 scenario: the start time is earlier 
or later than the parameter. I don't see a reason why we should fast forward to 
the next scheduled day even when it hasn't reach the time in a day, so my 
suggestion to change the line to `next_start.time() > self._schedule_at` when 
the execute time is a parameter, which means we consider the next scheduled 
timepoints as the beginning of the DAG execution.
   
   ### Solving the problem
   
   `next_start.time() > self._schedule_at`
   
   ### Anything else
   
   _No response_
   
   ### Are you willing to submit PR?
   
   - [X] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of 
Conduct](https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to