potiuk commented on code in PR #34951:
URL: https://github.com/apache/airflow/pull/34951#discussion_r1359881765
##########
dev/provider_packages/tag_providers.sh:
##########
@@ -35,6 +35,18 @@ do
{ git tag "${tag}" -m "Release $(date '+%Y-%m-%d') of providers" &&
tags+=("$tag") ; } || true
fi
done
+
if [[ -n "${tags:-}" && "${#tags}" -gt 0 ]]; then
- git push $remote "${tags[@]}"
+ if git push $remote "${tags[@]}"; then
+ echo "Tags pushed successfully"
Review Comment:
I think the original code was correct (and simpler).
```
if git push $remote "${tags[@]}"; then
```
would still output the stdout/stderr to terminal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
