potiuk commented on code in PR #34349:
URL: https://github.com/apache/airflow/pull/34349#discussion_r1359888351
##########
airflow/www/extensions/init_views.py:
##########
@@ -308,5 +318,16 @@ def init_api_experimental(app):
"The authenticated user has full access.",
RemovedInAirflow3Warning,
)
+ base_paths.append("/api/experimental")
app.register_blueprint(endpoints.api_experimental,
url_prefix="/api/experimental")
app.extensions["csrf"].exempt(endpoints.api_experimental)
+
+
+def init_api_auth_provider(app):
+ """Initialize the API offered by the auth manager."""
+ auth_mgr = get_auth_manager()
+ blueprint = auth_mgr.get_api_blueprint()
+ if blueprint is not None:
+ base_paths.append(blueprint.url_prefix)
+ app.register_blueprint(blueprint)
+ app.extensions["csrf"].exempt(blueprint)
Review Comment:
> Sounds good to me. Do we want to return flask.Blueprint or FlaskApi for
get_api_endpoints? Also, since for now we do not need get_ui_blueprints, do you
still want to have it? We could also add it when needed
* I think FlaskAPI is better
* I believe we need to add get_ui_blueprints - should not we have the whole
"Security" menu added via blueprints ? This whole menu section should be gone
where FAB auth manager is not configured.
I think this could be a separate PR, but it's still needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
