Taragolis commented on code in PR #34996:
URL: https://github.com/apache/airflow/pull/34996#discussion_r1362556606


##########
airflow/providers/cncf/kubernetes/operators/spark_kubernetes.py:
##########
@@ -111,6 +111,11 @@ def _get_namespace_event_stream(self, namespace, 
query_kwargs=None):
                 raise
 
     def execute(self, context: Context):
+        if isinstance(self.application_file, str):
+            body = _load_body_to_dict(self.application_file)
+        else:
+            body = self.application_file

Review Comment:
   As we 
[discuss](https://github.com/apache/airflow/discussions/34993#discussioncomment-7303893)
 previously this changes also required:
   1. Change docstring
   2. Write tests 
https://github.com/apache/airflow/blob/main/tests/providers/cncf/kubernetes/operators/test_spark_kubernetes.py



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to