dmedora commented on code in PR #34982:
URL: https://github.com/apache/airflow/pull/34982#discussion_r1362613278
##########
airflow/providers/google/cloud/hooks/gcs.py:
##########
@@ -1326,6 +1326,11 @@ def _prepare_sync_plan(
for current_name in names_to_check:
source_blob = source_names_index[current_name]
destination_blob = destination_names_index[current_name]
+ # If either object is CMEK-protected, use the Cloud Storage
Objects Get API to retrieve them so that the crc32c is included
+ if source_blob.kms_key_name != None:
Review Comment:
Updated in latest commit, thanks.
##########
airflow/providers/google/cloud/hooks/gcs.py:
##########
@@ -1326,6 +1326,11 @@ def _prepare_sync_plan(
for current_name in names_to_check:
source_blob = source_names_index[current_name]
destination_blob = destination_names_index[current_name]
+ # If either object is CMEK-protected, use the Cloud Storage
Objects Get API to retrieve them so that the crc32c is included
+ if source_blob.kms_key_name != None:
+ source_blob = source_bucket.get_blob(source_blob.name)
+ if destination_blob.kms_key_name != None:
Review Comment:
Updated in latest commit, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
