uranusjr commented on code in PR #34729: URL: https://github.com/apache/airflow/pull/34729#discussion_r1363371466
########## airflow/operators/file_transfer.py: ########## @@ -0,0 +1,76 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +from __future__ import annotations + +import shutil +from typing import TYPE_CHECKING + +from airflow.io.fsspec import FsspecFileIO +from airflow.models import BaseOperator + +if TYPE_CHECKING: + from airflow.io import InputFile, OutputFile + from airflow.utils.context import Context + + +class FileTransfer(BaseOperator): Review Comment: I didn’t even know we have GenericTransfer. FWIW I’m thinking about potentially extending this operator to cover copying from SQL to a (say Parquet) file, but that would make the “File” part a bit awkward. But maybe that lives better in a separate operator instead. Not sure. For the purpose this covers at the momemnt, FileTransferOperator sounds good to me. ########## airflow/operators/file_transfer.py: ########## @@ -0,0 +1,76 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +from __future__ import annotations + +import shutil +from typing import TYPE_CHECKING + +from airflow.io.fsspec import FsspecFileIO +from airflow.models import BaseOperator + +if TYPE_CHECKING: + from airflow.io import InputFile, OutputFile + from airflow.utils.context import Context + + +class FileTransfer(BaseOperator): Review Comment: I didn’t even know we have GenericTransfer. FWIW I’m thinking about potentially extending this operator to cover copying from SQL to a (say Parquet) file, but that would make the “File” part a bit awkward. But maybe that lives better in a separate operator instead. Not sure. For the purpose this covers at the momemnt, FileTransferOperator sounds good to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
