potiuk opened a new pull request, #35013:
URL: https://github.com/apache/airflow/pull/35013
So far, we regenerated the constraints in order to get them updated in
constraint branches at the end of the CI build when we knew all the builds
succeded. However this was not perfect for two reasons:
* there was a race condition that a dependency had been released between the
time images were built and tests completed. While it had no impact on "source"
constraints (they reflect what is in the image), it could change the PyPI
constraints generated or "no-providers" constraints, because they use "current"
set of dependencies in PyPI to generate them.
* generating constraints (for PyPI and "no-providers") takes time because
`pip` has to resolve dependencies again - taking into account what is in the
PyPI registry, and this can take a long time (minutes or even it can lead to
long `pip` backtracking. We generally cancel running builds when new commit is
merged in main, so this could lead to such constraint job being canceled by
subsequent merge
This PR uses the fact that we have now "preview-constraints" job that
uploads constraints as artifacts in CI workflow, and instead of regenerating
the constraints, we can download the constraints from uploaded artifact and use
it - this is very quick and we can also make a clear dependency between
"preview" and "update" constraints jobs - making it clear in case of PIP
backtracking that we have problem with constraints, not with the image. This
will make it far clearer when we will have problems with constraints and
backtracking that this is the real issue we have (allowing such PRs to get
merged while constraints backtracking problem is being worked on.
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)**
for more information.
In case of fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a
newsfragment file, named `{pr_number}.significant.rst` or
`{issue_number}.significant.rst`, in
[newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
