Owen-CH-Leung commented on PR #34735:
URL: https://github.com/apache/airflow/pull/34735#issuecomment-1768322831

   Thanks @kimminw00. Yes it makes sense to me. Different apps should have 
different names for differentiation. I've customized the yaml files to have 
different `app.kubernetes.io/name` instead of a single definition for all (i.e. 
differernt resource will have `app.kubernetes.io/name` like `airflow-flower`, 
`airflow-redis`, `airflow-statsd` and so on).
   
   I also put webserver, scheduler, dag processor, triggerer, worker to have 
similar app name (i.e. `airflow-webserver`, `airflow-scheduler` etc) even 
though they use the same image since they are seperate sub-applications. But 
for jobs like `create-user-job`, `run-airflow-migration` etc, I didn't put this 
label for now. 
   
   Let me know your thought on this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to