hussein-awala commented on PR #35026: URL: https://github.com/apache/airflow/pull/35026#issuecomment-1769427274
> but there also you will see reinstallation only happening if you change requirements.txt. And yes - in this case it will be a bit faster when you just add one requirement, but this will also work for the same user when rebuilding the image over and over again on the same machine I agree, it will be useful in the CI when https://github.com/moby/buildkit/issues/1512 will be implemented, in that case we can combine it with Github cache to persist the mounted cache. This could work now if we replace `--mount=type=cache,target=<path>` by `--mount=type=bind,source=<path>,target=<path>`, but it will impact the users who don't have a cache folder in their host. > I am not totally against it, but I would love to understand your case, because a) maybe you do not gain as much as you think or b) maybe you are doing somethign that prevents you from using docker layer caching or c) maybe you are using the Dockerfile of Airlfow in unintended way. This might be useful to someone playing with the requirements file to resolve a conflict, so if there is no potential risk from this change I would be OK with merging it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
