utkarsharma2 commented on code in PR #35052:
URL: https://github.com/apache/airflow/pull/35052#discussion_r1365792559
##########
airflow/providers/microsoft/azure/secrets/key_vault.py:
##########
@@ -127,7 +134,13 @@ def client(self) -> SecretClient:
if all([self.tenant_id, self.client_id, self.client_secret]):
credential = ClientSecretCredential(self.tenant_id,
self.client_id, self.client_secret)
else:
- credential = DefaultAzureCredential()
+ if all([self.managed_identity_client_id,
self.workload_identity_tenant_id]):
+ credential = DefaultAzureCredential(
Review Comment:
```suggestion
if self.managed_identity_client_id and
self.workload_identity_tenant_id:
credential = DefaultAzureCredential(
```
Since it's just two values we need to check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
