potiuk commented on code in PR #35000:
URL: https://github.com/apache/airflow/pull/35000#discussion_r1368972060


##########
airflow/www/security_manager.py:
##########
@@ -290,23 +323,36 @@ def has_access(self, action_name: str, resource_name: 
str, user=None) -> bool:
 
         Example actions might include can_read, can_write, can_delete, etc.
 
+        This function is called by FAB when accessing a view. See

Review Comment:
   Then my bet will be on changing the inheritance/decorator. Seems like mostly 
automate'able and way faster to complete, and if I am not mistaken - we want to 
get rid of the FAB dependence (and ideally/eventually make it provider 
dependency not core dependency if possible). Not sure if this would be possible 
even now, but it should be our end-goal (but maybe I am do not understand the 
extent of it of course and how tightly coupled it is). 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to