Taragolis commented on PR #35142: URL: https://github.com/apache/airflow/pull/35142#issuecomment-1776133631
> Do you think of some concrete methods that we should also mark as private in this case? Maybe that is a good opportunity to mark them as private indeed. Difficult to say which one should be accessed in context and which one shouldn't. I think r/o property it is safe to use, a lot of others might break something if it run in runtime or it might required additional access to DB. So better double check it. I assume that provide access to this methods to DAG Authors might be not a good idea. Some of them not documented, some of them could change behaviour of scheduled tasks https://github.com/apache/airflow/blob/1fdc2311250fbae47749822b192a99066600f8ad/airflow/models/dagrun.py#L644-L646 https://github.com/apache/airflow/blob/1fdc2311250fbae47749822b192a99066600f8ad/airflow/models/dagrun.py#L1386-L1398 https://github.com/apache/airflow/blob/1fdc2311250fbae47749822b192a99066600f8ad/airflow/models/dagrun.py#L857-L866 https://github.com/apache/airflow/blob/1fdc2311250fbae47749822b192a99066600f8ad/airflow/models/dagrun.py#L807-L810 https://github.com/apache/airflow/blob/1fdc2311250fbae47749822b192a99066600f8ad/airflow/models/dagrun.py#L272-L273 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
