DPGrev commented on a change in pull request #5671: [AIRFLOW-5049] Add
validation for src_fmt_configs in bigquery hook
URL: https://github.com/apache/airflow/pull/5671#discussion_r313260059
##########
File path: airflow/contrib/hooks/bigquery_hook.py
##########
@@ -1199,11 +1185,26 @@ def run_load(self, # pylint:
disable=too-many-locals,too-many-arguments,invalid
'PARQUET': ['autodetect', 'ignoreUnknownValues'],
'AVRO': ['useAvroLogicalTypes'],
}
+
valid_configs = src_fmt_to_configs_mapping[source_format]
- src_fmt_configs = {
- k: v
- for k, v in src_fmt_configs.items() if k in valid_configs
- }
+
+ # if following fields are not specified in src_fmt_configs,
Review comment:
Sure I will make the change!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
